Fix #438: Zero effective_amount_raised in cancel_campaign - #718
Conversation
cancel_campaign (and admin_cancel_campaign) now set campaign.effective_amount_raised = 0 to prevent stale values from persisting on cancelled campaigns. claim_refund is also guarded: the effective_amount_raised deduction is skipped for cancelled campaigns, since the value is already zeroed at cancel time and attempting to subtract from zero would overflow.
|
@meem08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
this is the more complete of the two PRs for #438 (the other being #604). zeroing a few asks:
gate: |
closes #438
closes #451